Match connection string variable to test-resources override for communication samples #11826
Conversation
benbp
requested review from
0rland0Wats0n,
ankitarorabit,
DominikMe,
RezaJooyandeh and
a team
as code owners
|
@RezaJooyandeh @DominikMe can one of you guys please take a look and at these changes? |
|
/azp run js - smoke-tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@benbp does this affect the test pipelines that run the test in livemode? |
|
/azp run js - communication-administration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-chat - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
@minnieliu @RezaJooyandeh now that the test is moving beyond the initial error, I'm seeing a 404 from the communication-sms sendSms.js test with the url that ends up getting constructed from test-resources.json: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=574949&view=logs&j=f3570516-c8fe-5ce9-92b2-b737df25d5ea&t=f7e12054-28e8-5a56-a94b-45551d60467c&l=1222 Do either of you have an idea of the issue here? |
|
@turalf @DominikMe @0rland0Wats0n what was the decision for sendSms here? Are we disabling it for now till we have static resource setup?
|
Yes, for now it should be skipped. We will be creating telephony resources on demand as well in a test subscription. (I have started an email thread on this) |
benbp
force-pushed
the
benbp/smoke-test-communication-svc
branch
from
edc7a69
to
4d1bb1c
Compare
|
/azp run js - smoke-tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
benbp
force-pushed
the
benbp/smoke-test-communication-svc
branch
from
4d1bb1c
to
2ebb5aa
Compare
|
The linux smoke tests are getting timed out, but the specific issues this PR addresses are fixed (https://dev.azure.com/azure-sdk/internal/_build/results?buildId=576644&view=logs&j=f3570516-c8fe-5ce9-92b2-b737df25d5ea&t=f7e12054-28e8-5a56-a94b-45551d60467c). |
|
/check-enforcer override |
The smoke tests are failing because the env variable override in test-resources.json injects a value for COMMUNICATION_CONNECTION_STRING, but most of the samples call for
process.env["CONNECTION_STRING"]. This PR updates all samples and README docs to reference the longer, scoped connection string environment variable.Azure/azure-sdk#1934